benwtrent commented on code in PR #14181:
URL: https://github.com/apache/lucene/pull/14181#discussion_r1936115985
##########
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswConcurrentMergeBuilder.java:
##########
@@ -190,12 +191,25 @@ private int getStartPos(int maxOrd) {
}
}
+ @Override
+ public void addGraphNode(int node, UpdateableRandomVectorScorer scorer)
throws IOException {
+ if (initializedNodes != null && initializedNodes.get(node)) {
+ return;
+ }
+ super.addGraphNode(node, scorer);
+ }
+
@Override
public void addGraphNode(int node) throws IOException {
if (initializedNodes != null && initializedNodes.get(node)) {
return;
}
- super.addGraphNode(node);
+ if (scorer == null) {
+ scorer = scorerSupplier.scorer(node);
Review Comment:
Let me see if I can adjust the interface a bit to ensure that we allow a
"null" scorer supplier that simply initializes the buffer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
