benwtrent commented on code in PR #14181: URL: https://github.com/apache/lucene/pull/14181#discussion_r1934697182
########## lucene/codecs/src/java/org/apache/lucene/codecs/bitvectors/FlatBitVectorsScorer.java: ########## @@ -58,7 +59,7 @@ public RandomVectorScorer getRandomVectorScorer( throw new IllegalArgumentException("vectorValues must be an instance of ByteVectorValues"); } - static class BitRandomVectorScorer implements RandomVectorScorer { + static class BitRandomVectorScorer implements UpdateableRandomVectorScorer { private final ByteVectorValues vectorValues; private final int bitDimensions; private final byte[] query; Review Comment: agh, `query` isn't a copy here. need to fix that... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org