benwtrent commented on code in PR #14094: URL: https://github.com/apache/lucene/pull/14094#discussion_r1930581288
########## lucene/core/src/java/org/apache/lucene/search/HnswKnnCollector.java: ########## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.search; + +/** {@link KnnCollector} that exposes methods to hook into specific parts of the HNSW algorithm. */ +public interface HnswKnnCollector extends KnnCollector { + + /** Indicates exploration of the next HNSW candidate graph node. */ + void nextCandidate(); +} Review Comment: I think this kind of collector is OK. But it makes most sense to me to be a delegate collector. An abstract collector to `KnnCollector.Delegate`. Then, I also think that the `OrdinalTranslatingKnnCollector` should inherit directly from `HnswKnnCollector` always assuming that the passed in collector is a `HnswKnnCollector`. Note, the default behavior for `HnswKnnCollector#nextCandidate` can simply be nothing, allowing for overriding. This might require a new `HnswGraphSearcher#search` interface to keep the old collector actions, but it can be simple to add a new one that accepts a `HnswKnnCollector` and delegate to it with `new HnswKnnCollector(KnnCollector delegate)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
