msokolov opened a new pull request, #14157:
URL: https://github.com/apache/lucene/pull/14157

   should fix #gh-14127 test failures.
   
   I believe there are no back-compat concerns here since this would be a no-op 
for graphs with no duplicates (I think that is what we were always producing 
before), and even if we did produce dups before, this will produce a 
functionally-equivalent graph, just a bit more compact.
   
   I also don't think we need to take any special action w.r.t. to the 
CheckIndex check that was added since if we never produced dups without 
reordering then it won't randomly start failing on indexes that checked out OK 
before.  Although there is some chance I'm wrong - it's difficult to *prove* we 
could not have produced duplicates before, I think we would have seen problems 
by now with the CheckIndex check having been out in the wild on main and 10x 
branch? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to