ChrisHegarty commented on PR #14156: URL: https://github.com/apache/lucene/pull/14156#issuecomment-2604854418
The overhead of `MS::isLoaded` is certainly not a good tradeoff here, as can be seen from the profile that you posted @original-brownbear. Given the new code, `consecutivePrefetchHitCount` doesn't seem effective now at all. Additionally, and orthogonally, I'm less sure of the checks anyway, since they don't count the against the actual memory range but rather against the whole segment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
