benwtrent commented on PR #14085: URL: https://github.com/apache/lucene/pull/14085#issuecomment-2599706155
The brute force drop occurs when the visit limit is breached. You can see this in abstract knn query. I only count visited on vector comparisons. So filtered search will explore the graph more before dropping to brute force. I do think we will always need a "drop to brute force" to catch edge cases but we need to make the calculation on when to do brute force upfront better. Right now it's pretty naive. I tried this a little in my change (see changes in hnsw reader), but it can be much better. As for exposing this to users, I am thinking it needs to be a setting on the knn query that gets passed to the collector. This is a pretty big change in search behavior -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
