benchaplin commented on PR #14085: URL: https://github.com/apache/lucene/pull/14085#issuecomment-2591282248
Awesome stuff @benwtrent - thanks for spearheading the luceneutil recall fix, still trying to wrap my head around how I followed so many "patterns" in those numbers during initial development when I guess they were all... bogus? Anyway, glad you were able to get back the gains. I like your idea to look past 2-hop nbs to a point (from what I can tell, that's what you're doing now with `filteredNeighborQueue.add(twoHopFriendOrd);`). I'm struggling to understand the reasoning behind the definitions of `expandedNeighborCount` & `maxExpandedNeighbors` though. I'll pull your branch and play around with some parameters. Also been working on adding correlated filters to luceneutil so should be able to test with that soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
