msokolov commented on code in PR #14019:
URL: https://github.com/apache/lucene/pull/14019#discussion_r1865914609
##########
lucene/core/src/java/org/apache/lucene/index/IndexWriter.java:
##########
@@ -141,7 +141,7 @@
* soon as a new commit is done. Creating your own policy can allow you to
explicitly keep previous
* "point in time" commits alive in the index for some time, either because
this is useful for your
* application, or to give readers enough time to refresh to the new commit
without having the old
- * commit deleted out from under them. The latter is necessary when multiple
computers take turns
+ * commit deleted under their hands. The latter is necessary when multiple
computers take turns
Review Comment:
this sounds like an idiom of sort, but I've never heard it -- I think the
existing phrasing is more idiomatic of the English I know anyway.
##########
lucene/core/src/java/org/apache/lucene/index/IndexWriterConfig.java:
##########
@@ -509,28 +509,28 @@ public IndexWriterConfig
setCheckPendingFlushUpdate(boolean checkPendingFlushOnU
}
/**
- * Sets the soft deletes field. A soft delete field in lucene is a
doc-values field that marks a
- * document as soft-deleted if a document has at least one value in that
field. If a document is
- * marked as soft-deleted the document is treated as if it has been
hard-deleted through the
+ * Sets the soft-deletes field. A soft-delete field in Lucene is a
doc-values field that marks a
+ * document as soft-deleted, if a document has at least one value in that
field. If a document is
+ * marked as soft-deleted, the document is treated as if it has been
hard-deleted through the
* IndexWriter API ({@link IndexWriter#deleteDocuments(Term...)}. Merges
will reclaim soft-deleted
- * as well as hard-deleted documents and index readers obtained from the
IndexWriter will reflect
- * all deleted documents in it's live docs. If soft-deletes are used
documents must be indexed via
+ * as well as hard-deleted documents, and index readers obtained from the
IndexWriter will reflect
+ * all deleted documents in its live docs. If soft-deletes are used,
documents must be indexed via
* {@link IndexWriter#softUpdateDocument(Term, Iterable, Field...)}. Deletes
are applied via
* {@link IndexWriter#updateDocValues(Term, Field...)}.
*
* <p>Soft deletes allow to retain documents across merges if the merge
policy modifies the live
* docs of a merge reader. {@link SoftDeletesRetentionMergePolicy} for
instance allows to specify
- * an arbitrary query to mark all documents that should survive the merge.
This can be used to for
- * example keep all document modifications for a certain time interval or
the last N operations if
- * some kind of sequence ID is available in the index.
+ * an arbitrary query to mark all documents that should survive the merge.
This can be used, for
+ * example, to keep all document modifications for a certain time interval
or the last N
+ * operations if some kind of sequence ID is available in the index.
*
* <p>Currently there is no API support to un-delete a soft-deleted
document. In oder to un-delete
Review Comment:
Can we fix "In oder" to be "In order"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
