viliam-durina commented on PR #14019: URL: https://github.com/apache/lucene/pull/14019#issuecomment-2511016616
Thanks for the review :+1: I reverted all the disputed changes, agree we should not go into unproductive discussions. I added a few new ones, they are in a separate commit to simplify the review. I'll only have note to the `writer ... who` (https://github.com/apache/lucene/pull/14019#discussion_r1864958353) - "who" should be used only for persons, this writer is not a person. But I reverted it anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
