mdmarshmallow commented on code in PR #13951:
URL: https://github.com/apache/lucene/pull/13951#discussion_r1859552804
##########
lucene/core/src/java/org/apache/lucene/index/IndexWriterConfig.java:
##########
@@ -142,7 +142,21 @@ public IndexWriterConfig() {
* problem you should switch to {@link LogByteSizeMergePolicy} or {@link
LogDocMergePolicy}.
*/
public IndexWriterConfig(Analyzer analyzer) {
- super(analyzer);
+ this(analyzer, new
IndexWriterRAMManager(IndexWriterConfig.DEFAULT_RAM_BUFFER_SIZE_MB));
Review Comment:
I think the reason I had to make all the changes in the test was cause I
added. this constructor:
` public IndexWriterConfig(IndexWriterRAMManager indexWriterRAMManager) {`
And then in the tests there were a bunch of `new IndexWriterConfig(null)`
calls which became ambiguous. I think that this constructor is potentially
useful which is why I took the hit and changed all those tests, but I can
remove it to avoid all those test changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
