msfroh commented on PR #13987: URL: https://github.com/apache/lucene/pull/13987#issuecomment-2494486990
> @msfroh FWIW I'm happy to merge this PR when we remove the double call to LeafCollector#collect on the same doc ID in tests. In that case, the unit test that I added can be removed (since the double-call to LeafCollector#collect was the whole point). The old code had the correct behavior if we don't call collect twice for the same doc. We can simplify/clarify it like https://github.com/apache/lucene/pull/14012 (which is functionally equivalent to what was there, but maybe a little clearer). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
