msfroh commented on code in PR #13987: URL: https://github.com/apache/lucene/pull/13987#discussion_r1842729383
########## lucene/core/src/test/org/apache/lucene/search/TestTopFieldCollector.java: ########## @@ -359,7 +359,7 @@ public void testTotalHitsWithScore() throws Exception { leafCollector.collect(1); scorer.score = 4; - leafCollector.collect(1); + leafCollector.collect(2); Review Comment: With the change, the call to `leafCollector.collect(1)` would get a score of 3 (since it's cached for document 1), instead of the 4 that the test expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org