benchaplin commented on PR #13887: URL: https://github.com/apache/lucene/pull/13887#issuecomment-2483785234
@dweiss you mentioned in my previous PR that I should do some randomized testing. I did, which helped me find the "Addition of "\\" in the negation set" requirement. However I just translated the key test cases to unit tests for this PR. Did you want me to commit this kind of randomized test? If so, I was thinking I'd have to introduce a snapshotting mechanism to record the output of oldParser(testTerm) as a baseline and compare it against newParser(testTerm) to catch any unintended changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
