uschindler commented on PR #13986: URL: https://github.com/apache/lucene/pull/13986#issuecomment-2473792705
> > > Personally I would prefer a less if/else/default handling using Optional like done in the previous sysprops. > > > > > > I'll make that change before merging. > > Well... I tried, and it was awful! The reason being the need to parseInt the value and catch the exception, which, while possible, just lead to more convoluted code. Easy to refactor later, if at all. I would have left the code to bail out if the Sysprop is empty or no valid integer, so not catch exception at all. Anyways, it's good as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
