dweiss commented on code in PR #13986:
URL: https://github.com/apache/lucene/pull/13986#discussion_r1836911525
##########
gradle/testing/defaults-tests.gradle:
##########
@@ -128,7 +128,13 @@ allprojects {
jvmArgs '--add-modules', 'jdk.management'
// Enable the vector incubator module on supported Java versions:
- if
(rootProject.vectorIncubatorJavaVersions.contains(rootProject.runtimeJavaVersion))
{
+ def v = JavaVersion.VERSION_1_1
+ def prop =
providers.systemProperty("org.apache.lucene.vectorization.upperJavaFeatureVersion")
Review Comment:
It'd be probably more consistent to use the propertyOrDefault "function"
that we defined globally to allow passing such properties via -P (gradle's
project properties) or -D (system properties). You can provide the default as
the second argument - look at any existing call of that function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
