msokolov commented on PR #13872: URL: https://github.com/apache/lucene/pull/13872#issuecomment-2465450838
Yeah I think I will stop working on this. Where I've ended up is with suspicions about the ScorerSupplier/Scorer setup. Because we allocate Scorers *a lot* we rely on that being a cheap operation, but ideally we should not have to create an object (actually a factory for creating objects, and then the object) in order to compare two vectors. The VectorValues knows where its vectors are, maybe it ought to do the comparison and worry about whether it needs to copy or can avoid it. Although when we repetitively compare against a known vector, that is one a case where it makes sense to me that we'd want to create an object representing that cached value-comparison. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
