msokolov commented on code in PR #13872:
URL: https://github.com/apache/lucene/pull/13872#discussion_r1834763594
##########
lucene/core/src/java/org/apache/lucene/index/FloatVectorValues.java:
##########
@@ -118,6 +123,9 @@ public Floats vectors() {
public float[] get(int ord) throws IOException {
return vectors.get(ord);
}
+
+ @Override
Review Comment:
oops this is redundant
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99ScalarQuantizedVectorsReader.java:
##########
@@ -428,6 +428,11 @@ public Floats vectors() throws IOException {
public float[] get(int ord) throws IOException {
return rawVectors.get(ord);
}
+
+ @Override
+ public void close() throws IOException {
+ rawVectors.close();
Review Comment:
these changes to the quantized reader/writer might be needed, but not just
for the Floats case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
