goankur commented on code in PR #13572: URL: https://github.com/apache/lucene/pull/13572#discussion_r1817245059
########## lucene/core/src/java/org/apache/lucene/codecs/lucene99/OffHeapQuantizedByteVectorValues.java: ########## @@ -146,6 +146,7 @@ public float getScoreCorrectionConstant(int targetOrd) throws IOException { } slice.seek(((long) targetOrd * byteSize) + numBytes); slice.readFloats(scoreCorrectionConstant, 0, 1); + lastOrd = targetOrd; Review Comment: Got it!. I will remove this in the next revision. I was just trying to optimize for the case when `getScoreCorrectionConstant(int targetOrd)` gets invoked with the same `targetOrd` multiple times in succession. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org