mikemccand commented on PR #13572: URL: https://github.com/apache/lucene/pull/13572#issuecomment-2435099386
@goankur -- thank you for pulling out the actual native code into a new `native` Lucene module. I'm not sure we need a new module -- could we use `misc` or `sandbox` maybe? I have not looked so closely at the PR, just left a few minor comments so far, but ... how come there are so many changes necessary in `core`? It looks like a lot of hard forking of existing sources to specialize specific cases (memory segment, byte quentization, ???). I had expected (from the view from 10000 feet) the PR to be nearly entirely outside of `core`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
