cpoerschke commented on code in PR #13757:
URL: https://github.com/apache/lucene/pull/13757#discussion_r1756534635
##########
lucene/core/src/java/org/apache/lucene/search/similarities/DFRSimilarity.java:
##########
@@ -94,6 +94,26 @@ public class DFRSimilarity extends SimilarityBase {
*/
public DFRSimilarity(
BasicModel basicModel, AfterEffect afterEffect, Normalization
normalization) {
+ this(basicModel, afterEffect, normalization, true);
+ }
+
+ /**
+ * Creates DFRSimilarity from the three components.
+ *
+ * <p>Note that <code>null</code> values are not allowed: if you want no
normalization, instead
+ * pass {@link NoNormalization}.
+ *
+ * @param basicModel Basic model of information content
+ * @param afterEffect First normalization of information gain
+ * @param normalization Second (length) normalization
+ * @param discountOverlaps True if overlap tokens (tokens with a position of
increment of zero)
Review Comment:
Good catch!
```suggestion
* @param discountOverlaps True if overlap tokens (tokens with a position
of increment of zero)
* are discounted from the document's length.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
