rmuir commented on PR #13757:
URL: https://github.com/apache/lucene/pull/13757#issuecomment-2344714065

   > Thanks, that makes sense. I'm wondering if we should remove the 
discountOverlap parameter from our similarities, and add support for it via a 
Similarity wrapper somehow, that would wrap/clone the FieldInvertState that is 
passed to computeNorm.
   
   I don't like that this wacky index-time encoding is in Similarity class 
myself, it happens at a totally different time ("index time") than the rest of 
Similarity logic ("search time"), and you have to pass your Similarity to both 
IndexWriter and IndexSearcher, making it more confusing to the user and more 
complicated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to