javanna commented on code in PR #13747: URL: https://github.com/apache/lucene/pull/13747#discussion_r1756305014
########## lucene/join/src/java/org/apache/lucene/search/join/MergeableCollector.java: ########## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.search.join; + +import java.io.IOException; +import org.apache.lucene.search.Collector; + +interface MergeableCollector<C extends MergeableCollector<C>> extends Collector { + + /** Folds the results from another collector of the same type into this collector. */ + void merge(C collector) throws IOException; +} Review Comment: I wonder if we need to introduce these new abstractions: MergeableCollector and MergeableCollectorManager. I can see what you are up to, many times we use Collector themselves to reduce multiple collectors into. I am not a big fan of that design though, it seems like a quick way to move to using collector managers, but ideally what reduce and hence the search method returns isn't a collector, and we would not use collectors to retrieve state after search is executed. How much more complicated would the code be without these new concepts, writing the collector managers that are needed and adding that logic to reduce? Would that cause a lot of code duplication? ########## lucene/join/src/java/org/apache/lucene/search/join/MergeableCollector.java: ########## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.search.join; + +import java.io.IOException; +import org.apache.lucene.search.Collector; + +interface MergeableCollector<C extends MergeableCollector<C>> extends Collector { + + /** Folds the results from another collector of the same type into this collector. */ + void merge(C collector) throws IOException; +} Review Comment: Another take at this, maybe `merge` does not fit that well in a `Collector` design but we could have a base collector manager impl that exposes the same merge method. After all, I think merging should be a collector manager's concern? Maybe we would even call it reduce: `protected C reduce(C collector);` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
