benwtrent commented on code in PR #13641:
URL: https://github.com/apache/lucene/pull/13641#discussion_r1755503855
##########
lucene/codecs/src/test/org/apache/lucene/codecs/simpletext/TestSimpleTextKnnVectorsFormat.java:
##########
@@ -41,4 +41,14 @@ public void testRandomBytes() throws Exception {
public void testSortedIndexBytes() throws Exception {
// unimplemented
}
+
+ @Override
+ public void testMergingWithDifferentKnnFields() {
+ // unimplemented
+ }
+
+ @Override
+ public void testMergingWithDifferentByteKnnFields() {
+ // unimplemented
+ }
Review Comment:
Simple text and per field are left over from before me fixing vector
merging. For the others, only the `byte` version is overridden because those
older formats didn't support bytes.
Will push up a commit soon to make sure perfield and simple run this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
