benwtrent commented on PR #13641: URL: https://github.com/apache/lucene/pull/13641#issuecomment-2344006469
OK, I pushed up a fix for @msokolov's suggestion and your reminder @jpountz . I added a protection around our access to the KnnVectorReaders during merge. Additionally, I kept my new test, but these protections keep it from throwing (previously it did). This way we unify our access logic on missing (e.g. throw), and protect during merge by not attempting to access vector values that aren't there for a given field. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
