mikemccand commented on code in PR #13707:
URL: https://github.com/apache/lucene/pull/13707#discussion_r1743879304
##########
lucene/core/src/java/org/apache/lucene/util/automaton/Operations.java:
##########
@@ -857,22 +857,38 @@ public static boolean isEmpty(Automaton a) {
return true;
}
- /** Returns true if the given automaton accepts all strings. The automaton
must be minimized. */
+ /** Returns true if the given automaton accepts all strings. */
public static boolean isTotal(Automaton a) {
return isTotal(a, Character.MIN_CODE_POINT, Character.MAX_CODE_POINT);
}
/**
* Returns true if the given automaton accepts all strings for the specified
min/max range of the
- * alphabet. The automaton must be minimized.
+ * alphabet.
Review Comment:
Add that the automaton must be determinized? And maybe explain the CPU
cost is `O(T)` (`T` = total number of transitions) -- linear in total
transition count?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
