rmuir commented on code in PR #13707: URL: https://github.com/apache/lucene/pull/13707#discussion_r1743877792
########## lucene/core/src/java/org/apache/lucene/util/automaton/Operations.java: ########## @@ -857,22 +857,38 @@ public static boolean isEmpty(Automaton a) { return true; } - /** Returns true if the given automaton accepts all strings. The automaton must be minimized. */ + /** Returns true if the given automaton accepts all strings. */ Review Comment: for some NFA, it might return `false` when in fact the NFA is "total", I think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org