msfroh commented on PR #13521: URL: https://github.com/apache/lucene/pull/13521#issuecomment-2315946796
@mikemccand -- did you mean to close this PR? If @expani adds the unrolled version (`Bit21With3StepsEncoder`) to `DocIdsWriter`, the change should be ready to go, IMO. Even on x86, I'm seeing a consistent slight improvement with the unrolled version (see the benchmark runs I posted above) -- `Bit21With3StepsEncoder` is always a little bit faster. (I've done about a dozen more runs, as I've been fighting with my SIMD implementation.) While the unrolled version is a bit more code, it's a little faster on x86 and much faster on aarch64. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
