expani commented on PR #13521: URL: https://github.com/apache/lucene/pull/13521#issuecomment-2298718372
While trying out 2 different ways ( one a subset of other ) I found that `Bit21With3StepsEncoder` is better than `Bit21With2StepsEncoder` in aarch64 platforms with OpenJDK 21/22 whereas they are similar in x86. x86 EC2 instance type `c5.9xlarge` ``` Benchmark (encoderName) Mode Cnt Score Error Units DocIdEncodingBenchmark.performEncodeDecode Bit21With3StepsEncoder avgt 5 6905.920 ± 33.626 ms/op DocIdEncodingBenchmark.performEncodeDecode Bit21With2StepsEncoder avgt 5 6983.592 ± 8.864 ms/op DocIdEncodingBenchmark.performEncodeDecode Bit24Encoder avgt 5 7795.338 ± 78.580 ms/op ``` aarch64 - EC2 instance type `r6g.large` ``` Benchmark (encoderName) Mode Cnt Score Error Units DocIdEncodingBenchmark.performEncodeDecode Bit21With3StepsEncoder avgt 5 7736.603 ± 82.581 ms/op DocIdEncodingBenchmark.performEncodeDecode Bit21With2StepsEncoder avgt 5 8705.315 ± 123.062 ms/op DocIdEncodingBenchmark.performEncodeDecode Bit24Encoder avgt 5 8767.359 ± 179.656 ms/op ``` JDK ``` openjdk version "22.0.2" 2024-07-16 OpenJDK Runtime Environment Corretto-22.0.2.9.1 (build 22.0.2+9-FR) OpenJDK 64-Bit Server VM Corretto-22.0.2.9.1 (build 22.0.2+9-FR, mixed mode, sharing) ``` @jpountz IMO We should use `Bit21With3StepsEncoder` in DocIdsWriter as using `Bit21With2StepsEncoder` might cause regression for workloads in aarch64 platforms. We can replace it with `Bit21With2StepsEncoder` in future when the performance is comparable to x86. Let me know your thoughts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
