gsmiller commented on issue #13671: URL: https://github.com/apache/lucene/issues/13671#issuecomment-2313193985
Cool, sounds like we've got a good plan. I'll just add that I've been noodling on the idea for a while of seeing if we could actually get rid of `DrillSideways` and fold what it does into `IndexSearcher` in a way that's not specific to faceting. One use-case I've been playing with is the idea of generically being able to produce multiple match sets during a single query evaluation where each match set is a "near miss" as drill-sideways defines it. This is exactly what `DrillSideways` does, but it's tightly coupled to faceting. If we're trying to make drill-sideways more generic to work with any `CollectorManager`, I'd like to see if we could bake this into `IndexSearcher`. Maybe we could explore this with option 2 or 3 as a follow-up? I'll create an issue as soon as I have time to describe the use-case in more detail with some examples, etc. to motivate it. In the meantime though, as far as moving forward with Option 1 goes, I think it's a little more than just pulling out the `IndexSearcher` API right @epotyom? I think we need a new method in `DrillSideways` that lets users pass in `CollectorManager`s for the sideways dims (since right now it assumes you want facet collectors)? Maybe we add a method that takes in a `Supplier<CollectorManager>` or something for the sideways dims? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
