gsmiller commented on issue #13671: URL: https://github.com/apache/lucene/issues/13671#issuecomment-2312763368
Thanks @epotyom for the detailed thoughts! If I'm understanding this correctly, it sounds like "option 1" would let us remove the need for `CollectorOwner` along with the new API in `IndexSearcher` while still supporting drill-sideways use with the new sandbox faceting implementation, but the same aggregations would need to be done across all dimensions? One thing I like about that option is that it separates out the concerns of, 1) making sure drill-sideways can work with the new faceting implementation, and 2) extending the capabilities of drill-sideways further to allow for different aggregations for certain dimensions (which I agree sounds useful, but also pretty uncommon). I think options 2 and 3 are both things we should consider more as a follow-up, but I think it could take some time to get it right and build consensus, which I'm not sure we have ahead of a planned 10.0 release. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
