ChrisHegarty commented on code in PR #13651:
URL: https://github.com/apache/lucene/pull/13651#discussion_r1731488489
##########
lucene/core/src/java21/org/apache/lucene/internal/vectorization/PanamaVectorUtilSupport.java:
##########
@@ -761,4 +763,81 @@ private static int squareDistanceBody128(MemorySegment a,
MemorySegment b, int l
// reduce
return acc1.add(acc2).reduceLanes(ADD);
}
+
+ @Override
+ public long ipByteBinByte(byte[] q, byte[] d) {
+ if (VECTOR_BITSIZE == 128) {
Review Comment:
Yeah, the implementation only works on ARM at the minute. I'm iterating on
an x64 implementation, but haven't found the sweet spot yet. I'll merge
something soon and share the jmh benchmarks. In fact, the problem on x64 is
vectorization! for our small(ish) loop iterations, since each dimension is a
single bit, then it typically hurts to vectorize. And Hotspot keeps
auto-vectorising even my trivial scalar loops.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
