rmuir commented on code in PR #13651:
URL: https://github.com/apache/lucene/pull/13651#discussion_r1731174206
##########
lucene/core/src/java21/org/apache/lucene/internal/vectorization/PanamaVectorUtilSupport.java:
##########
@@ -761,4 +763,81 @@ private static int squareDistanceBody128(MemorySegment a,
MemorySegment b, int l
// reduce
return acc1.add(acc2).reduceLanes(ADD);
}
+
+ @Override
+ public long ipByteBinByte(byte[] q, byte[] d) {
+ if (VECTOR_BITSIZE == 128) {
Review Comment:
@ChrisHegarty I'm confused about this, what if machine has avx-256? Also
since this uses integers there must be a check for
`PanamaVectorConstants.HAS_FAST_INTEGER_VECTORS`. on machines without avx,
`VECTOR_BITSIZE` of 128 will be claimed, but any operations will be 30x slower.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
