msfroh commented on PR #13543: URL: https://github.com/apache/lucene/pull/13543#issuecomment-2305315023
> this change was merged: did you observe any change in the flame graphs? Yes! We were benchmarking on Lucene 9.11 and saw the time spent in `growIfNeeded` on JDK21 (and about a 7% slowdown in indexing versus JDK17). I noticed this change in my local clone of main, cherry-picked it onto the 9.11 branch, and subsequent JDK21 runs caught up with JDK17. It helped a lot -- not for the biased locking deprecation (which went into JDK15), but because it bypassed these extra comparisons that were added to support virtual threads. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
