jpountz commented on code in PR #13592:
URL: https://github.com/apache/lucene/pull/13592#discussion_r1725906610
##########
lucene/core/src/test/org/apache/lucene/search/TestDocValuesQueries.java:
##########
@@ -42,34 +45,100 @@
public class TestDocValuesQueries extends LuceneTestCase {
+ private Codec getCodec() {
+ // small interval size to test with many intervals
+ return TestUtil.alwaysDocValuesFormat(new
Lucene90DocValuesFormat(random().nextInt(4, 16)));
+ }
+
public void testDuelPointRangeSortedNumericRangeQuery() throws IOException {
- doTestDuelPointRangeNumericRangeQuery(true, 1);
+ doTestDuelPointRangeNumericRangeQuery(true, 1, false);
+ }
+
+ public void testDuelPointRangeSortedNumericRangeWithSlipperQuery() throws
IOException {
+ doTestDuelPointRangeNumericRangeQuery(true, 1, true);
}
public void testDuelPointRangeMultivaluedSortedNumericRangeQuery() throws
IOException {
- doTestDuelPointRangeNumericRangeQuery(true, 3);
+ doTestDuelPointRangeNumericRangeQuery(true, 3, false);
+ }
+
+ public void
testDuelPointRangeMultivaluedSortedNumericRangeWithSkipperQuery() throws
IOException {
+ doTestDuelPointRangeNumericRangeQuery(true, 3, true);
}
public void testDuelPointRangeNumericRangeQuery() throws IOException {
- doTestDuelPointRangeNumericRangeQuery(false, 1);
+ doTestDuelPointRangeNumericRangeQuery(false, 1, false);
}
- private void doTestDuelPointRangeNumericRangeQuery(boolean sortedNumeric,
int maxValuesPerDoc)
- throws IOException {
+ public void testDuelPointRangeNumericRangeWithSkipperQuery() throws
IOException {
+ doTestDuelPointRangeNumericRangeQuery(false, 1, true);
+ }
+
+ public void testDuelPointNumericSortedWithSkipperRangeQuery() throws
IOException {
+ Directory dir = newDirectory();
+ IndexWriterConfig config = new IndexWriterConfig();
+ config.setIndexSort(new Sort(new SortField("dv", SortField.Type.LONG,
random().nextBoolean())));
+ RandomIndexWriter iw = new RandomIndexWriter(random(), dir, config);
+ config.setCodec(getCodec());
Review Comment:
can you move the call to `setCodec` before the IndexWriter is created? since
the codec is not supposed to be updateable (the setter is only on
IndexWriterConfig, not LiveIndexWriterConfig), it would be legal for
IndexWriter to cache the codec that it gets at creation time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
