gsmiller commented on code in PR #13592:
URL: https://github.com/apache/lucene/pull/13592#discussion_r1725418294
##########
lucene/core/src/java/org/apache/lucene/index/DocValuesSkipper.java:
##########
@@ -98,4 +98,29 @@ public abstract class DocValuesSkipper {
/** Return the global number of documents with a value for the field. */
public abstract int docCount();
+
+ /**
+ * Advance this skipper so that all levels intersects the range given by
{@code minValue} and
+ * {@code maxValue}. If there are no intersecting levels, the skipper is
exhausted.
+ *
+ * <p><b>NOTE</b>: The behavior is undefined if this method is called and
{@link #advance(int)}
+ * has not been called yet.
+ */
+ public final void advance(long minValue, long maxValue) throws IOException {
+ while (true) {
Review Comment:
Good point. I can't think of a good reason why we shouldn't do this? It
would make the API a little easier for callers. I suppose it adds a very slight
overhead to the call, but seems trivial.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
