jpountz commented on code in PR #13672:
URL: https://github.com/apache/lucene/pull/13672#discussion_r1725706940


##########
lucene/core/src/test/org/apache/lucene/search/TestDocValuesRewriteMethod.java:
##########
@@ -61,14 +61,19 @@ public void setUp() throws Exception {
                 .setMaxBufferedDocs(TestUtil.nextInt(random(), 50, 1000)));
     List<String> terms = new ArrayList<>();
     int num = atLeast(200);
+    boolean createDocValueSkiplist = random().nextBoolean();

Review Comment:
   Maybe split the test so that we test both cases explicitly every time?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to