rmuir commented on code in PR #13672:
URL: https://github.com/apache/lucene/pull/13672#discussion_r1722557603
##########
lucene/core/src/test/org/apache/lucene/search/TestDocValuesRewriteMethod.java:
##########
@@ -61,14 +61,19 @@ public void setUp() throws Exception {
.setMaxBufferedDocs(TestUtil.nextInt(random(), 50, 1000)));
List<String> terms = new ArrayList<>();
int num = atLeast(200);
+ boolean createDocValueSkiplist = random().nextBoolean();
for (int i = 0; i < num; i++) {
Document doc = new Document();
doc.add(newStringField("id", Integer.toString(i), Field.Store.NO));
int numTerms = random().nextInt(4);
for (int j = 0; j < numTerms; j++) {
String s = TestUtil.randomUnicodeString(random());
doc.add(newStringField(fieldName, s, Field.Store.NO));
- doc.add(new SortedSetDocValuesField(fieldName, new BytesRef(s)));
+ if (createDocValueSkiplist == false) {
+ doc.add(new SortedSetDocValuesField(fieldName, new BytesRef(s)));
+ } else {
+ doc.add(SortedSetDocValuesField.indexedField(fieldName, new
BytesRef(s)));
+ }
Review Comment:
can we swap order so that there's no negated comparison. it is always easier
to read
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
