ChrisHegarty commented on issue #13659: URL: https://github.com/apache/lucene/issues/13659#issuecomment-2296727766
> I mean it would be nice if we didn't generate these degenerate Component in the first place? But this will work I had the same thought, but then backed away quickly! ;-) . I think that @benwtrent's fix is the safest thing to do here. There are several usages of `Component` that are a little less clear to me, but we minimally need to create such `new Component(NO_MORE_DOCS, x)`, where `x` is greater than equal to `0`, for such things as determining `componentSizes`. Maybe the javadoc in `Component` could be updated to hint a little more at the potential usages. But that can be done separately, if at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
