benwtrent commented on issue #13659:
URL: https://github.com/apache/lucene/issues/13659#issuecomment-2291853791

   From what I can tell:
   
    - `components` will return  a component where the entry_point is 
`NO_MORE_DOCS`
    - This occurs because the `notFullyConnected.nextSetBit(0);` returns 
`NO_MORE_DOCS`
    - When checking for connectedness, we look at `size` not entry point
    ```
         // connect other components to the largest one
         Component c0 = 
components.stream().max(Comparator.comparingInt(Component::size)).get();
   ```
   
   I am not sure what the behavior should be here, but it seems to me that a 
component whose entry point is `NO_MORE_DOCS` shouldn't get added to the 
components list.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to