gsmiller commented on PR #13656:
URL: https://github.com/apache/lucene/pull/13656#issuecomment-2289330332
Also, benchmarks (wikimedium10m) comparing this PR to the tip of main seems
to indicate it reverses the performance impact we observed in the nightly runs:
```
TaskQPS baseline StdDevQPS
my_modified_version StdDev Pct diff p-value
OrHighNotMed 514.50 (7.8%) 450.63
(8.0%) -12.4% ( -26% - 3%) 0.000
BrowseDayOfYearSSDVFacets 12.31 (17.6%) 11.25
(14.8%) -8.7% ( -34% - 28%) 0.093
OrHighNotHigh 736.67 (5.7%) 681.57
(5.8%) -7.5% ( -17% - 4%) 0.000
OrHighNotLow 540.78 (8.0%) 501.87
(5.7%) -7.2% ( -19% - 7%) 0.001
Fuzzy2 62.59 (9.4%) 61.15
(6.3%) -2.3% ( -16% - 14%) 0.362
BrowseDateSSDVFacets 2.28 (18.0%) 2.23
(20.5%) -2.2% ( -34% - 44%) 0.720
PKLookup 138.88 (9.4%) 135.97
(9.0%) -2.1% ( -18% - 18%) 0.471
AndHighMedDayTaxoFacets 94.46 (7.4%) 92.84
(8.5%) -1.7% ( -16% - 15%) 0.495
TermDTSort 201.98 (9.6%) 198.97
(7.3%) -1.5% ( -16% - 17%) 0.581
AndHighLow 1481.23 (4.9%) 1461.85
(5.2%) -1.3% ( -10% - 9%) 0.414
HighPhrase 133.81 (5.5%) 132.64
(5.2%) -0.9% ( -11% - 10%) 0.607
LowPhrase 144.74 (3.7%) 143.77
(2.5%) -0.7% ( -6% - 5%) 0.501
LowSpanNear 176.09 (3.2%) 174.97
(2.4%) -0.6% ( -6% - 5%) 0.480
OrNotHighMed 316.14 (7.1%) 314.30
(6.9%) -0.6% ( -13% - 14%) 0.794
BrowseRandomLabelTaxoFacets 15.74 (22.4%) 15.66
(21.3%) -0.5% ( -36% - 55%) 0.939
HighTermTitleSort 103.22 (7.7%) 102.82
(6.9%) -0.4% ( -13% - 15%) 0.867
OrNotHighHigh 273.54 (7.2%) 272.64
(5.2%) -0.3% ( -11% - 12%) 0.868
AndHighHighDayTaxoFacets 18.05 (7.7%) 18.05
(7.4%) 0.0% ( -13% - 16%) 0.996
HighTermDayOfYearSort 336.99 (11.2%) 338.19
(8.7%) 0.4% ( -17% - 22%) 0.910
MedPhrase 54.51 (9.5%) 54.91
(8.2%) 0.7% ( -15% - 20%) 0.795
MedIntervalsOrdered 19.45 (4.2%) 19.60
(5.0%) 0.7% ( -8% - 10%) 0.616
MedSloppyPhrase 108.50 (5.2%) 109.33
(5.6%) 0.8% ( -9% - 12%) 0.653
BrowseDateTaxoFacets 23.33 (24.9%) 23.52
(25.2%) 0.8% ( -39% - 67%) 0.916
Wildcard 506.91 (4.2%) 511.80
(5.6%) 1.0% ( -8% - 11%) 0.539
AndHighMed 428.85 (4.2%) 433.08
(4.0%) 1.0% ( -6% - 9%) 0.448
BrowseMonthTaxoFacets 24.39 (25.2%) 24.67
(25.8%) 1.1% ( -39% - 69%) 0.887
HighTermMonthSort 1073.70 (3.8%) 1087.16
(4.9%) 1.3% ( -7% - 10%) 0.364
OrHighMedDayTaxoFacets 10.65 (6.4%) 10.79
(6.1%) 1.3% ( -10% - 14%) 0.524
OrNotHighLow 1218.33 (4.8%) 1235.66
(2.9%) 1.4% ( -5% - 9%) 0.252
MedTermDayTaxoFacets 33.99 (6.8%) 34.48
(7.7%) 1.4% ( -12% - 17%) 0.528
BrowseDayOfYearTaxoFacets 23.89 (25.2%) 24.28
(24.7%) 1.6% ( -38% - 69%) 0.837
AndHighHigh 165.85 (8.0%) 169.19
(7.1%) 2.0% ( -12% - 18%) 0.400
Respell 44.10 (7.4%) 45.01
(7.6%) 2.1% ( -12% - 18%) 0.384
LowIntervalsOrdered 66.23 (6.0%) 67.61
(8.2%) 2.1% ( -11% - 17%) 0.364
OrHighLow 420.34 (6.2%) 429.68
(6.4%) 2.2% ( -9% - 15%) 0.265
HighTermTitleBDVSort 45.89 (7.9%) 47.02
(7.1%) 2.5% ( -11% - 19%) 0.303
Fuzzy1 64.64 (7.6%) 66.39
(8.9%) 2.7% ( -12% - 20%) 0.300
OrHighMed 384.44 (3.6%) 395.46
(3.2%) 2.9% ( -3% - 10%) 0.008
OrHighHigh 194.21 (7.1%) 199.80
(7.3%) 2.9% ( -10% - 18%) 0.206
HighSpanNear 58.20 (2.9%) 59.91
(3.6%) 2.9% ( -3% - 9%) 0.004
BrowseMonthSSDVFacets 11.00 (10.9%) 11.36
(13.7%) 3.2% ( -19% - 31%) 0.412
HighSloppyPhrase 16.33 (6.5%) 16.88
(7.3%) 3.3% ( -9% - 18%) 0.128
Prefix3 492.96 (16.6%) 509.78
(11.3%) 3.4% ( -21% - 37%) 0.448
MedSpanNear 97.89 (3.1%) 101.67
(4.2%) 3.9% ( -3% - 11%) 0.001
HighIntervalsOrdered 46.46 (10.2%) 48.54
(8.6%) 4.5% ( -12% - 25%) 0.134
BrowseRandomLabelSSDVFacets 7.45 (9.0%) 7.79
(13.4%) 4.6% ( -16% - 29%) 0.205
LowSloppyPhrase 172.46 (18.1%) 181.88
(13.7%) 5.5% ( -22% - 45%) 0.281
IntNRQ 164.75 (20.3%) 178.95
(22.5%) 8.6% ( -28% - 64%) 0.203
LowTerm 712.28 (4.9%) 795.97
(6.7%) 11.7% ( 0% - 24%) 0.000
MedTerm 441.32 (5.1%) 575.99
(10.0%) 30.5% ( 14% - 48%) 0.000
HighTerm 387.23 (10.4%) 522.80
(10.3%) 35.0% ( 12% - 62%) 0.000
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
