gsmiller commented on PR #13656: URL: https://github.com/apache/lucene/pull/13656#issuecomment-2289311663
Benchmarks (`wikimedium10m`) comparing this change to `9b481f76f77b40a5061fb3b70763e4b4a06d31d0` (last commit on main before #13568) show no performance regression, which is what we're looking for (except maybe AndHighLow, but I think it's possible that's noise): ``` TaskQPS baseline StdDevQPS my_modified_version StdDev Pct diff p-value IntNRQ 237.96 (12.6%) 229.18 (13.6%) -3.7% ( -26% - 25%) 0.374 AndHighLow 1639.08 (4.6%) 1581.66 (4.8%) -3.5% ( -12% - 6%) 0.019 BrowseDateSSDVFacets 2.32 (20.8%) 2.24 (20.2%) -3.3% ( -36% - 47%) 0.611 HighTermDayOfYearSort 326.64 (10.0%) 316.00 (11.8%) -3.3% ( -22% - 20%) 0.345 MedSloppyPhrase 65.44 (8.4%) 63.33 (11.7%) -3.2% ( -21% - 18%) 0.316 Fuzzy1 76.87 (8.1%) 74.64 (4.6%) -2.9% ( -14% - 10%) 0.165 Respell 42.45 (9.5%) 41.32 (8.2%) -2.7% ( -18% - 16%) 0.341 OrNotHighHigh 536.69 (6.7%) 523.57 (5.9%) -2.4% ( -14% - 10%) 0.221 Fuzzy2 55.68 (8.5%) 54.61 (7.7%) -1.9% ( -16% - 15%) 0.452 MedPhrase 253.20 (6.5%) 248.42 (6.6%) -1.9% ( -14% - 11%) 0.361 PKLookup 144.54 (7.3%) 142.18 (10.5%) -1.6% ( -18% - 17%) 0.570 HighIntervalsOrdered 29.42 (5.7%) 28.94 (5.8%) -1.6% ( -12% - 10%) 0.376 LowSloppyPhrase 311.38 (3.5%) 307.46 (3.9%) -1.3% ( -8% - 6%) 0.284 Wildcard 276.55 (3.4%) 273.33 (3.7%) -1.2% ( -7% - 6%) 0.295 OrHighLow 619.71 (4.7%) 612.64 (4.3%) -1.1% ( -9% - 8%) 0.427 AndHighHigh 253.59 (5.0%) 250.83 (4.8%) -1.1% ( -10% - 9%) 0.482 HighTermTitleSort 115.63 (6.4%) 114.39 (6.1%) -1.1% ( -12% - 12%) 0.588 AndHighMedDayTaxoFacets 45.88 (5.0%) 45.40 (5.9%) -1.0% ( -11% - 10%) 0.546 MedSpanNear 93.76 (2.2%) 92.96 (2.7%) -0.9% ( -5% - 4%) 0.273 HighSpanNear 32.47 (2.7%) 32.21 (2.6%) -0.8% ( -6% - 4%) 0.343 OrHighNotMed 388.49 (9.4%) 385.41 (7.8%) -0.8% ( -16% - 18%) 0.771 MedTermDayTaxoFacets 21.82 (7.0%) 21.65 (6.2%) -0.8% ( -12% - 13%) 0.710 HighTermMonthSort 1160.65 (5.0%) 1152.21 (3.9%) -0.7% ( -9% - 8%) 0.610 HighSloppyPhrase 29.69 (6.7%) 29.48 (6.3%) -0.7% ( -12% - 13%) 0.734 HighPhrase 99.10 (4.0%) 98.45 (4.7%) -0.7% ( -9% - 8%) 0.639 AndHighHighDayTaxoFacets 12.21 (7.9%) 12.19 (7.3%) -0.2% ( -14% - 16%) 0.936 AndHighMed 492.38 (3.9%) 491.57 (4.6%) -0.2% ( -8% - 8%) 0.903 BrowseRandomLabelSSDVFacets 8.27 (10.0%) 8.27 (12.4%) -0.0% ( -20% - 24%) 0.991 LowPhrase 94.06 (5.4%) 94.08 (3.6%) 0.0% ( -8% - 9%) 0.992 LowTerm 821.86 (3.1%) 822.44 (4.3%) 0.1% ( -7% - 7%) 0.953 LowSpanNear 85.68 (2.3%) 85.79 (1.5%) 0.1% ( -3% - 4%) 0.833 LowIntervalsOrdered 120.61 (2.8%) 120.80 (3.2%) 0.2% ( -5% - 6%) 0.869 HighTerm 497.73 (7.4%) 498.92 (6.8%) 0.2% ( -12% - 15%) 0.915 OrHighMedDayTaxoFacets 6.23 (4.9%) 6.25 (5.1%) 0.3% ( -9% - 10%) 0.835 OrHighMed 366.78 (4.7%) 367.99 (3.5%) 0.3% ( -7% - 9%) 0.802 HighTermTitleBDVSort 56.14 (8.2%) 56.45 (8.5%) 0.6% ( -14% - 18%) 0.833 OrHighHigh 146.90 (6.3%) 147.84 (6.4%) 0.6% ( -11% - 14%) 0.750 Prefix3 477.09 (3.8%) 481.48 (3.4%) 0.9% ( -6% - 8%) 0.418 OrNotHighLow 1088.31 (3.2%) 1100.43 (2.7%) 1.1% ( -4% - 7%) 0.232 MedIntervalsOrdered 103.59 (11.3%) 105.08 (10.6%) 1.4% ( -18% - 26%) 0.680 BrowseDayOfYearSSDVFacets 11.52 (14.8%) 11.71 (16.5%) 1.7% ( -25% - 38%) 0.738 OrHighNotLow 509.35 (7.5%) 517.82 (7.1%) 1.7% ( -12% - 17%) 0.471 OrNotHighMed 552.12 (5.8%) 562.17 (7.0%) 1.8% ( -10% - 15%) 0.369 MedTerm 493.55 (5.6%) 503.71 (8.4%) 2.1% ( -11% - 16%) 0.361 OrHighNotHigh 296.92 (7.4%) 305.21 (7.8%) 2.8% ( -11% - 19%) 0.244 TermDTSort 249.52 (7.5%) 257.04 (7.4%) 3.0% ( -11% - 19%) 0.200 BrowseMonthSSDVFacets 11.46 (8.9%) 12.11 (20.2%) 5.7% ( -21% - 38%) 0.245 BrowseDateTaxoFacets 22.85 (28.3%) 24.18 (21.3%) 5.8% ( -34% - 77%) 0.461 BrowseRandomLabelTaxoFacets 15.44 (23.7%) 16.48 (18.2%) 6.7% ( -28% - 63%) 0.313 BrowseMonthTaxoFacets 23.78 (26.4%) 25.59 (22.6%) 7.6% ( -32% - 77%) 0.326 BrowseDayOfYearTaxoFacets 22.97 (27.1%) 25.06 (23.2%) 9.1% ( -32% - 81%) 0.254 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org