goankur commented on code in PR #13572: URL: https://github.com/apache/lucene/pull/13572#discussion_r1701070122
########## lucene/core/src/c/dotProduct.h: ########## @@ -0,0 +1,4 @@ + +int32_t vdot8s_sve(int8_t* vec1[], int8_t* vec2, int32_t limit); +int32_t vdot8s_neon(int8_t* vec1[], int8_t* vec2[], int32_t limit); +int32_t dot8s(int8_t* a, int8_t* b, int32_t limit); Review Comment: Prototypes fixed and `dotProduct.h` included in `dotProduct.c`. I did not add `-Wall -Werror` yet as after including changes from your patch the compilation of `dotProduct.c` file fails for me on Graviton boxes. Let's continue that discussion in the separate thread. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
