rmuir commented on code in PR #13572:
URL: https://github.com/apache/lucene/pull/13572#discussion_r1697474113
##########
lucene/core/src/c/dotProduct.c:
##########
@@ -0,0 +1,143 @@
+// dotProduct.c
+
+#include <stdio.h>
+#include <arm_neon.h>
+
+#ifdef __ARM_ACLE
+#include <arm_acle.h>
+#endif
+
+#if (defined(__ARM_FEATURE_SVE) && !defined(__APPLE__))
+#include <arm_sve.h>
+/*
+ * Unrolled and vectorized int8 dotProduct implementation using SVE
instructions
+ * NOTE: Clang 15.0 compiler on Apple M3 Max compiles the code below
sucessfully
+ * with '-march=native+sve' option but throws "Illegal Hardware Instruction"
error
+ * Looks like Apple M3 does not implement SVE and Apple's official
documentation
+ * is not explicit about this or at least I could not find it.
+ *
+ */
+int32_t vdot8s_sve(int8_t *vec1, int8_t *vec2, int32_t limit) {
+ int32_t result = 0;
+ int32_t i = 0;
+ // Vectors of 8-bit signed integers
+ svint8_t va1, va2, va3, va4;
+ svint8_t vb1, vb2, vb3, vb4;
+ // Init accumulators
+ svint32_t acc1 = svdup_n_s32(0);
+ svint32_t acc2 = svdup_n_s32(0);
+ svint32_t acc3 = svdup_n_s32(0);
+ svint32_t acc4 = svdup_n_s32(0);
+
+ // Number of 8-bits elements in the SVE vector
+ int32_t vec_length = svcntb();
+
+ // Manually unroll the loop
+ for (i = 0; i + 4 * vec_length <= limit; i += 4 * vec_length) {
+ // Load vectors into the Z registers which can range from 128-bit to
2048-bit wide
+ // The predicate register - P determines which bytes are active
+ // svptrue_b8() returns a predictae in which every element is true
+ //
+ va1 = svld1_s8(svptrue_b8(), vec1 + i);
+ vb1 = svld1_s8(svptrue_b8(), vec2 + i);
+
+ va2 = svld1_s8(svptrue_b8(), vec1 + i + vec_length);
+ vb2 = svld1_s8(svptrue_b8(), vec2 + i + vec_length);
+
+ va3 = svld1_s8(svptrue_b8(), vec1 + i + 2 * vec_length);
+ vb3 = svld1_s8(svptrue_b8(), vec2 + i + 2 * vec_length);
+
+ va4 = svld1_s8(svptrue_b8(), vec1 + i + 3 * vec_length);
+ vb4 = svld1_s8(svptrue_b8(), vec2 + i + 3 * vec_length);
+
+ // Dot product using SDOT instruction on Z vectors
+ acc1 = svdot_s32(acc1, va1, vb1);
+ acc2 = svdot_s32(acc2, va2, vb2);
+ acc3 = svdot_s32(acc3, va3, vb3);
+ acc4 = svdot_s32(acc4, va4, vb4);
+ }
Review Comment:
maybe consider "vector tail", since 4 * vector length can be significant:
and vector dimensions may not be exact multiple of that. It limits the worst
case processing that "scalar tail" must do. Example from the java vector code:
https://github.com/apache/lucene/blob/main/lucene/core/src/java21/org/apache/lucene/internal/vectorization/PanamaVectorUtilSupport.java#L153-L158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
