original-brownbear commented on PR #13609: URL: https://github.com/apache/lucene/pull/13609#issuecomment-2258283776
@javanna > Perhaps we could at least write a test that fails without the change you made, around nulling memory? I'm really sorry. I thought about this quite a bit, but outside of actually testing that the callables go out of scope via some `Cleaner` magic I think there's no way to do this, all of the functionality is internal to the task executor class. There's just not really any functional change here, it's just that I made the `Callable`s get GCed quicker and saved a little bit of indirection in general. I think this might be one of these things where we have to trust the code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
