original-brownbear opened a new pull request, #13609: URL: https://github.com/apache/lucene/pull/13609
We can save some memory in failure scenarios here (and a tiny bit in every case) by moving our started flag to the `FutureTask` and using the callable outright. First of all, we save the wrapper callable, but that also allows us to just `set(null)` on cancellation instead of waiting for the task to run to set the `null`. In case we have longer running tasks executing and it would take a while to get to the cancelled tasks, this saves some memory and allows us to return from the method earlier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
