jpountz commented on PR #13585: URL: https://github.com/apache/lucene/pull/13585#issuecomment-2258120692
Thanks @mikemccand for taking a look at this large PR! I think I applied all your suggestions. The format docs should be up-to-date wrt how skip data is stored, and I did the codec dance (moving Lucene99PostingsFormat and Lucene99Codec to lucene/backward-codecs, making Lucene99PostingsFormat read-only, adding a test-only Lucene99RWPostingsFormat for testing, moving all our special terms dictionary formats to Lucene912PostingsFormat, moving the completion postings format to Lucene912PostingsFormat). Note that I removed `TestLazyProxSkipping`, which assumed separate skip data and postings. I plan on merging soon, as this PR is now in a state where conflicts easily arise and are hard to address. One cannot run luceneutil anymore as luceneutil complains that `Lucene99Codec` is missing, but my last run before doing the codec dance was very similar to the last one shared above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
