uschindler commented on PR #13570: URL: https://github.com/apache/lucene/pull/13570#issuecomment-2233498077
I am fine with everything - BUT: we should still check how the grouping works when for an existing segment an additional `*.del` file is updated (same for softdeletes and docvalues updates). If it is treated as same segment, at least for del files it would not cause too big issues (because those are quite small), but if we have in-place atomic updates, we could have files already closed and deleted, but arena still there. I will do some checks on Windows which is very sensitive with deleting still open files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
