magibney commented on PR #13570: URL: https://github.com/apache/lucene/pull/13570#issuecomment-2233474047
This is looking good. I think making it possible for MMapDirectory to customize/bypass grouping is still important -- something along the lines of what Uwe was thinking in [these](#issuecomment-2228827755) [comments](#issuecomment-2228845198): >>Maybe the file pattern should really be a Predicate to separate the implementation. Maybe add a method to return protected Optional<String> getArenaGroupingKey(String filename) (or as Function<String,Optional<String>>), which returns empty optional if no grouping allowed or the segment number otherwise as key. > >This could be similarily implemented like the setPreload(BiPredicate<String,IOContext>) method. >It could even be simpler by passing the grouping key to the provider method directly in addition to filename. Then the code that figures out which group is used can reside in MMapDirectory only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
