msokolov commented on code in PR #13561:
URL: https://github.com/apache/lucene/pull/13561#discussion_r1672846447
##########
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswConcurrentMergeBuilder.java:
##########
@@ -84,7 +88,8 @@ public OnHeapHnswGraph build(int maxOrd) throws IOException {
});
}
taskExecutor.invokeAll(futures);
- return workers[0].getGraph();
+ frozen = true;
+ return workers[0].getCompletedGraph();
Review Comment:
Yeah ... I guess this allows a little more strictness that we can't have in
the other case because this builder *only* allows building via `build()` method
wheras the other one can accept individual nodes. But perhaps consistency is
better and we should move this `frozen = true` into the `getCompletedGraph`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
