benwtrent commented on code in PR #13561:
URL: https://github.com/apache/lucene/pull/13561#discussion_r1672837709
##########
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswConcurrentMergeBuilder.java:
##########
@@ -84,7 +88,8 @@ public OnHeapHnswGraph build(int maxOrd) throws IOException {
});
}
taskExecutor.invokeAll(futures);
- return workers[0].getGraph();
+ frozen = true;
+ return workers[0].getCompletedGraph();
Review Comment:
Why are we freezing here instead of within `getCompletedGraph` like its done
for the single threaded builder?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
